quasar icon indicating copy to clipboard operation
quasar copied to clipboard

Verifier doesn't always spot issues

Open mikehearn opened this issue 9 years ago • 4 comments

If you forgot to annotate an abstract method in a superclass as @Suspendable then the verifier doesn't seem able to detect this mistake and impossible NPEs can result.

By the way, it'd be nice if the instrumentor could generate try/catch blocks for the code that generates the NPEs so you get a more helpful error than a stack trace pointing to a line that cannot possibly have generated it.

mikehearn avatar Mar 30 '16 10:03 mikehearn

I've added a test (needs to be run with -Dco.paralleluniverse.fibers.verifyInstrumentation=true) but I can't reproduce the issue. Is your case different?

circlespainter avatar Apr 05 '16 05:04 circlespainter

Hm, that's odd. It looks reasonably similar. Perhaps the final modifiers are different in our case, but that shouldn't make any difference. Or perhaps it's something to do with the cast at the top of the test block. I'll have a play with it soon.

mikehearn avatar Apr 05 '16 10:04 mikehearn

@mikehearn Have you had a chance to look into this? If you managed to find the difference, could you reproduce the issue in a small program and share it?

circlespainter avatar Apr 12 '16 08:04 circlespainter

I haven't had time to try minimising the test case, sorry. We set up the verifier ant job for now.

mikehearn avatar Apr 13 '16 11:04 mikehearn