comsat icon indicating copy to clipboard operation
comsat copied to clipboard

Added support for latest jOOQ version

Open roded opened this issue 9 years ago • 6 comments

Hi, Here's a start. I'm not sure about "comsat-jooq-latest", perhaps "comsat-jooq-java8" is more appropriate. Please let me know of any comments or reservations.

roded avatar Dec 29 '16 08:12 roded

Thank you! This looks good, but please change jooq-latest to jooq-java8 as you suggested. Also, take a look at the Quasar build file to see how to exclude subprojects from the build when built using Java 7.

pron avatar Dec 29 '16 12:12 pron

No problem. Could you be more explicit regarding the subproject build exclusion? Thanks

roded avatar Dec 29 '16 19:12 roded

On my machine, the exclusion of the tests from the sourceSet deletes the test class for some reason, not sure why..

roded avatar Jan 04 '17 09:01 roded

@pron Could you review the gradle solution to make sure it's appropriate? Anything else I can do to further this along? Thanks

roded avatar Jan 15 '17 15:01 roded

The sources & javadocs artifacts are inherited from the parent build.gradle it seems. Added them explicitly.

roded avatar Jan 19 '17 21:01 roded

The comsat-jooq-java8 build and tests seem OK. The reported build error is a test in the okhttp integration. A previous build for the same PR (with no changes to the PR code) failed in WebActorServletTest. I'm not sure if these are related to this PR.

roded avatar Jan 24 '17 15:01 roded