comsat icon indicating copy to clipboard operation
comsat copied to clipboard

Any plans 0.7.1 with Redis support

Open sheinbergon opened this issue 9 years ago • 6 comments

Hi

I'm aware of https://github.com/puniverse/comsat/issues/7

However , I also found this

https://github.com/circlespainter/quasar-redis-example

@circlespainter / @pron amazing work.

What is the plan to merge the 'redis' branch to the master and release 'comsat-redis' as a stable feature ?

Can I help with something ?

sheinbergon avatar Nov 08 '16 11:11 sheinbergon

@pron any comment ?

sheinbergon avatar Nov 11 '16 16:11 sheinbergon

comsat-redis implements Jedis only partially at this stage and, being a very young integration and notwithstanding the port of the test suite, there might well be serious bugs (e.g. performance or stability) when actually using it, so I'm not for releasing it immediately in an official stable.

It is also true that a wider user base would help with the sharp edges. @pron What do you think?

As for help sure, you could PR Jedis API coverage and more tests.

circlespainter avatar Dec 12 '16 17:12 circlespainter

Perhaps @sheinbergon can give it a try using the redis branch, and we'll decide based on his experience.

pron avatar Dec 13 '16 10:12 pron

Do you have any holes you'd like to cover in specific ? Concurrency tests ? I'm willing to help , just provide the what :-)

sheinbergon avatar Dec 13 '16 11:12 sheinbergon

Here are a few ideas:

  • Using it in a real-world scenario as @pron suggested and providing improvements / fixes as PRs (best option IMO)
  • Concurrency / load tests / benchmarks with analysis and improvement PRs
  • More Jedis API coverege (and associated tests port), you can find a comprehensive list of unimplemented features in https://github.com/circlespainter/quasar-redis-example

circlespainter avatar Dec 14 '16 17:12 circlespainter

@circlespainter @pron

OK . I'll run some manual tests for now the first chance I have and report back on the following subjects :

  • Functional tests
  • Load tests
  • Coverage tests ( based on importance )

sheinbergon avatar Dec 14 '16 17:12 sheinbergon