puNES icon indicating copy to clipboard operation
puNES copied to clipboard

Look for the FDS BIOS in the "bios" folder first

Open anewuser opened this issue 2 years ago • 3 comments

Currently, if you specify the FDS BIOS location, it saves the absolute path of the file, and there's no way to modify it to a relative path with the GUI. What about these ideas to make the emulator truly portable?

  • If you haven't manually specified a location for the FDS BIOS file, puNES could first automatically look for the BIOS in its own bios folder before giving an error
  • If you manually set a location inside the puNES folder, it could save it as a relative path

The same could be done for the Game Genie ROM.

anewuser avatar Aug 30 '21 15:08 anewuser

This can also be done.

punesemu avatar Aug 31 '21 06:08 punesemu

So, I'll explain how the search for both bios works (already now): If you have not entered any file in the "Settings->General", puNES looks for the bios in the "[puNES home]/bios" directory ("disksys.rom" for the FDS and "gamegenie.rom" for the GG) and if he doesn't find it he reports an error. If you have entered the file in the "Settings->General" he will try to load that first and if not find will look for the bios in the directory '[puNES home]/bios', if it's not found here it reports an error.

punesemu avatar Sep 07 '21 10:09 punesemu

It'd be safer to check the file hash, since No-Intro uses a different name and extension for the same file: [BIOS] Family Computer Disk System (Japan) (Rev 1).bin, and it can also be found with other names online.

An easier solution is to just mention the file name you expect and leave it up for the user to rename it: FDS Bios file (disksys.rom).

anewuser avatar Sep 07 '21 18:09 anewuser

@punesemu Since these files can also be found online with other names and extensions, what about just adding parentheses to these strings with the expected filenames?

FDS

You could also prompt for it the first time the user tries to load a Disk System image, like Nestopia UE does:

nestopia

puNES could also show an "Incompatible BIOS detected" message when disksys.rom doesn't match any of the supported files.

anewuser avatar Dec 04 '23 21:12 anewuser