puma icon indicating copy to clipboard operation
puma copied to clipboard

Allow alternative schemes in Binder

Open tomurb opened this issue 1 year ago • 3 comments

Description

Allows for adding before_parse hooks to the Binder#parse method.

Your checklist for this pull request

  • [x] I have reviewed the guidelines for contributing to this repository.
  • [x] I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • [x] My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • [x] If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • [x] If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • [x] I have updated the documentation accordingly.
  • [x] * All new and existing tests passed, including Rubocop.
  • tests went thorugh on my fork: https://github.com/tomurb/puma/actions

Closes #3302

tomurb avatar Mar 18 '24 21:03 tomurb

It would be good to document / show how one can use this (it is not entirely clear to me, even when I've read the linked issue, but I have also never developed a plugin for Puma)

Can something be added to https://github.com/puma/puma/blob/master/docs/plugins.md?

dentarg avatar Apr 02 '24 04:04 dentarg

I've added some documentation. I also didn't develop any plugins. I don't know how to write an example. I could maybe add that link for context and add how that change would make difference for acme-puma codebase? (change of the method name, and removal of lib/puma/acme/binder.rb file)

Does that sound right?

tomurb avatar Apr 03 '24 13:04 tomurb

could maybe add that link for context and add how that change would make difference for acme-puma codebase?

I think that would be good

dentarg avatar Apr 03 '24 17:04 dentarg