puma icon indicating copy to clipboard operation
puma copied to clipboard

Improve auto trim free thread condition

Open OuYangJinTing opened this issue 2 years ago • 1 comments

Description

When max_threads and min_threads are the same, it is no need to call auto_trim!, which can reduce one thread.

Your checklist for this pull request

  • [x] I have reviewed the guidelines for contributing to this repository.
  • [x] I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • [x] My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • [x] If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • [x] If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • [ ] I have updated the documentation accordingly.
  • [ ] All new and existing tests passed, including Rubocop.

PS: English is not my native language; please excuse typing errors.


Added @joshuay03 as a collaborator here, because @joshuay03 created a similar #3384 to fix this problem. Co-authored-by: Joshua Young [email protected]

OuYangJinTing avatar Jan 06 '24 15:01 OuYangJinTing

image It's normal for me to test locally. The test failed here, just because of the timeout, it should be ignored.

OuYangJinTing avatar Jun 14 '24 09:06 OuYangJinTing