puma icon indicating copy to clipboard operation
puma copied to clipboard

[CI] test_integration_ssl_session.rb - wait for session callback

Open MSP-Greg opened this issue 2 years ago • 0 comments

Description

I haven't seen any of these tests fail, but I have seen some retry. All of the tests create two ssl requests, and the SSLSockets have OpenSSL::SSL::SSLContext#session_new_cb set.

This PR adds code so the second request waits for the callback. The tests haven't failed/retried in the limited CI testing I've done.

Note that, like many of the tests involving 'retry', I've never had these tests fail locally.

Your checklist for this pull request

  • [x] I have reviewed the guidelines for contributing to this repository.
  • [x] I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • [x] My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • [ ] If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • [ ] If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • [x] I have updated the documentation accordingly.
  • [x] All new and existing tests passed, including Rubocop.

MSP-Greg avatar May 17 '23 19:05 MSP-Greg