registry icon indicating copy to clipboard operation
registry copied to clipboard

add wttech/pulumi-aem

Open dominik-przybyl-wttech opened this issue 1 year ago • 3 comments

Description

Add wttech/pulumi-aem to Pulumi Registry.

Adding a new package?

If this pull request adds a new package:

  • [x] The package's schema URL is correct.
  • [ ] The package metadata file, if present, contains:
    • [x] a supported category (one of Cloud, Infrastructure, Network, Database, Monitoring, or Utility).
    • [ ] a description that explains what the package does.
    • [x] a valid logo URL that points to a PNG whose dimensions conform to the others in this repo (e.g., 100x100).
    • [x] a version number prefixed with v that corresponds with a valid GitHub release.
  • [x] The package repo contains an Overview doc (/docs/_index.md) that includes:
    • [x] a brief explanation of what the package is and what it does.
    • [x] at least one representative example in all supported languages.
    • [x] a front-matter property for the layout set to package.
  • [ ] The package repo contains an Installation and Configuration doc (/docs/installation-configuration.md) that includes:
    • [x] links to SDKs in all supported languages.
    • [ ] a copyable command for installing the resource plugin if necessary.
    • [ ] an example of configuring the provider with pulumi config set.
    • [ ] an example of configuring the provider with environment variables.
  • [ ] A CODEOWNER has reviewed the PR.
  • [ ] A member of the @pulumi/docs team has reviewed all documentation.

dominik-przybyl-wttech avatar May 24 '24 10:05 dominik-przybyl-wttech

@krystian-panek-wttech @dominik-przybyl-wttech there are still a few issues from the list I reported earlier which are not resolved. Can you go over these please?

After fixing these, you have to make a release containing these fixes before we can can merge this PR.

ringods avatar Jun 17 '24 06:06 ringods

A new release is available: https://github.com/wttech/pulumi-aem/releases/tag/v0.1.2. I've fixed all mentioned issues. Regarding the Go SDK on pkg.go.dev, it is available: https://proxy.golang.org/github.com/wttech/pulumi-aem/sdk/@v/v0.1.2.info. However, it is not yet visible on pkg.go.dev. I am still working to resolve this. Is this a blocker, or can we proceed with adding the AEM provider to the Pulumi repository?

dominik-przybyl-wttech avatar Jun 20 '24 13:06 dominik-przybyl-wttech

@cnunciato would you have an idea why the Go documentation doesn't show up pkg.go.dev?

ringods avatar Jun 24 '24 18:06 ringods

@ringods, @cnunciato, @sean1588 Go documentation is now available on https://pkg.go.dev/github.com/wttech/pulumi-aem/sdk, can you continue the review?

dominik-przybyl-wttech avatar Aug 27 '24 22:08 dominik-przybyl-wttech

@dominik-przybyl-wttech will have a look today, but can you rebase your branch against master rather than merging master into your branch?

ringods avatar Aug 30 '24 06:08 ringods

@ringods, done

dominik-przybyl-wttech avatar Aug 30 '24 09:08 dominik-przybyl-wttech

@ringods, @cnunciato, @sean1588 is everything fine with this PR now, or is any additional work required?

dominik-przybyl-wttech avatar Sep 18 '24 21:09 dominik-przybyl-wttech

Thank you @ringods , good news

dominik-przybyl-wttech avatar Sep 24 '24 13:09 dominik-przybyl-wttech