registry icon indicating copy to clipboard operation
registry copied to clipboard

added a-schot/pulumi-dbtcloud to community package list

Open a-schot opened this issue 1 year ago • 8 comments

Description

Added a bridged provider for dbt Cloud.

  • The logo which can be used for the Pulumi Registry can be found here, couldn't find where to submit this, however.
  • Any tips on how to exclude the legacy dbt_cloud-prefixed resources would be much appreciated. I had to map them all to Legacy<resourcename>, otherwise the binary would panic.

Adding a new package?

If this pull request adds a new package:

  • [X] The package's schema URL is correct.
  • [X] The package metadata file, if present, contains:
    • [X] a supported category (one of Cloud, Infrastructure, Network, Database, Monitoring, or Utility).
    • [X] a description that explains what the package does.
    • [x] a valid logo URL that points to a PNG whose dimensions conform to the others in this repo (e.g., 100x100).
    • [x] a version number prefixed with v that corresponds with a valid GitHub release.
  • [X] The package repo contains an Overview doc (/docs/_index.md) that includes:
    • [X] a brief explanation of what the package is and what it does.
    • [X] at least one representative example in all supported languages.
    • [X] a front-matter property for the layout set to package.
  • [X] The package repo contains an Installation and Configuration doc (/docs/installation-configuration.md) that includes:
    • [X] links to SDKs in all supported languages.
    • [x] a copyable command for installing the resource plugin if necessary.
    • [X] an example of configuring the provider with pulumi config set.
    • [X] an example of configuring the provider with environment variables.
  • [ ] A CODEOWNER has reviewed the PR.
  • [ ] Someone from the @pulumi/docs team has reviewed all documentation.

a-schot avatar Feb 03 '24 21:02 a-schot

@ringods Thanks for the feedback!

I implemented the three points mentioned in your reply and ticked the boxes in the original PR text to reflect that.

a-schot avatar Apr 03 '24 12:04 a-schot

@a-schot I noticed an incorrect value for your download URL.

https://github.com/a-schot/pulumi-dbtcloud/commit/2330d98bc0e5f7ece439080d75c0910ed50c99d5#r140550943

After fixing the download URL, can you create a new release of your package containing all these changes?

ringods avatar Apr 03 '24 14:04 ringods

@ringods Good catch.

I fixed it and released a new version: https://github.com/a-schot/pulumi-dbtcloud/actions/runs/8540656535

a-schot avatar Apr 03 '24 15:04 a-schot

Hey @a-schot. I'm sorry to hear that about those extra legacy mappings. You shouldn't need to do that. Can you post a copy of the panic stack trace to https://github.com/pulumi/pulumi-terraform-bridge/issues/1838. We would like to fix this for you.

iwahbe avatar Apr 03 '24 17:04 iwahbe

@a-schot to ignore some of the legacy TF resources and not expose these in the Pulumi version, you should be able to use the IgnoreMappings property within provider/resources.go:

https://github.com/pulumi/pulumi-terraform-bridge/blob/9257734f4e75379fc05f0d99dd19b461111b44b1/pkg/tfbridge/info.go#L86

ringods avatar Apr 03 '24 18:04 ringods

@ringods It doesn't seem like that is happening right now. I am using that property currently for all dbt_cloud_ prefixed resources/datasources. This does prevent the errors thrown by tfgen but the binary will still panic at runtime (see my comment on pulumi/pulumi-terraform-bridge/issues/1838)

a-schot avatar Apr 03 '24 18:04 a-schot

@a-schot can you update the pulumi TF bridge in your provider to this release and retry?

https://github.com/pulumi/pulumi-terraform-bridge/releases/tag/v3.80.0

It includes this fix:

Do not map resources/datasources specified in IgnoreMappings

ringods avatar Apr 11 '24 08:04 ringods

@a-schot checking in again as we haven't heard from you in a few weeks. Would you have time to checkout this PR I created?

https://github.com/a-schot/pulumi-dbtcloud/pull/1

I upgraded the bridge and removed the legacy mappings.

ringods avatar Apr 30 '24 02:04 ringods

Closing in favor of the first-party package available in https://www.pulumi.com/registry/packages/dbtcloud/

mikhailshilkov avatar May 22 '24 12:05 mikhailshilkov