pulumi-kubernetesx icon indicating copy to clipboard operation
pulumi-kubernetesx copied to clipboard

Add support for metada in createService method

Open Oyelowo opened this issue 3 years ago • 1 comments

Problem

createService method on Deployment class uses deployment name with randomised suffix by default and has no means of defining custom name or namespace for a service. Of course, this can be done with the kx.Service class but it would be nice to provide overriding options in createService method.

This also uses deployment metadata name as service name by default rather than the deployment resource id which provides some stability.

This closes https://github.com/pulumi/pulumi-kubernetesx/issues/52 and https://github.com/pulumi/pulumi-kubernetesx/issues/73

Oyelowo avatar Feb 17 '22 20:02 Oyelowo

Following an internal conversation, we might not be able to release this immeidately as this component isn't actively supported - meaning some of the release mechanism requires additional updates which we've not got capacity to replace. But if you're happy to leave this open then we'll endevour to incorporate this change at the point we can invest more into this component.

Thanks again for the contribution here, sorry we can't get this shipped out as fast as we'd like.

danielrbradley avatar Feb 18 '22 13:02 danielrbradley

Due to lack of tests in this repo and the age, we're not in a good position to move this PR forward so closing for now.

mjeffryes avatar Mar 22 '24 23:03 mjeffryes