pulumi-kubernetes
pulumi-kubernetes copied to clipboard
Remove deprecated pkg/errors package
errors.Wrap
can mask bugs by returning nil
errors where a non-nil
error was intended. This is most common in situations where multiple errors are being checked and the wrong (nil
) error is wrapped:
if err != nil {
return err
}
if _, otherErr := f(...); otherErr != nil {
return errors.Wrap(err, ...) // bug
}
From spot checking our usage I don't think we have any cases of this, but we should stop using the deprecated package to be safe. Additionally the native errors package now has Join
and other helpers we should be using instead.
Most of this PR was programmatically generated.
Does the PR have any schema changes?
Looking good! No breaking changes found. No new resources/functions.
Codecov Report
Attention: Patch coverage is 0.81301%
with 122 lines
in your changes are missing coverage. Please review.
Project coverage is 29.99%. Comparing base (
80d60f4
) to head (333ebf0
).
Additional details and impacted files
@@ Coverage Diff @@
## master #2990 +/- ##
==========================================
+ Coverage 29.94% 29.99% +0.05%
==========================================
Files 63 63
Lines 8353 8338 -15
==========================================
Hits 2501 2501
+ Misses 5630 5615 -15
Partials 222 222
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.