pulumi-kubernetes-operator icon indicating copy to clipboard operation
pulumi-kubernetes-operator copied to clipboard

Published 20 hours ago • verified publisher icon pulumi

update stacks_failing metric to check pulumiv1.Stack instead of pulumiv1alpha1.Stack

Open bob-bins opened this issue 3 years ago • 3 comments

Proposed changes

Update stacks_failing metric to use the current v1 Stack API version instead of the outdated v1alpha1.

From my observations, the pulumi-k8s-operator automatically upgrades new applications of the Stack resources to v1 if they are applied with the older API version, so for new Stacks it should be fine that this PR does not account for the old API version. However, I don't know if the operator converts old Stack resources to the new version so whether not this is a breaking change is not known to me right now.

Related issues (optional)

https://github.com/pulumi/pulumi-kubernetes-operator/issues/307

Additional comments

I tested this locally, but I tested it with a base branch from the 1.7.0 release commit https://github.com/pulumi/pulumi-kubernetes-operator/commit/cb9f70c3bd1e983daa5fd9b2926ed386af56d4e0 instead of the latest master branch because the pulumi-k8s-operator was giving me errors when attempting to checkout the git branch: unable to checkout branch: reference not found

Somehow the change in https://github.com/pulumi/pulumi-kubernetes-operator/commit/ef96c6d7cd4aeeb185e757f0f5dcac445ef62c53 (specifically the change in https://github.com/pulumi/pulumi/pull/10118) did not work for me for both branch formats: refs/remotes/origin/foo and foo.

bob-bins avatar Aug 02 '22 00:08 bob-bins

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

github-actions[bot] avatar Aug 02 '22 00:08 github-actions[bot]

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

github-actions[bot] avatar Aug 02 '22 00:08 github-actions[bot]

I realized this is basically a duplicate of https://github.com/pulumi/pulumi-kubernetes-operator/pull/245, but I'm keeping this open since it's a less stale branch

bob-bins avatar Aug 02 '22 02:08 bob-bins

/run-acceptance-tests

lblackstone avatar Aug 18 '22 18:08 lblackstone

Please view the PR build - https://github.com/pulumi/pulumi-kubernetes-operator/actions/runs/2884514361

github-actions[bot] avatar Aug 18 '22 18:08 github-actions[bot]

Thanks for the PR @bob-bins! LGTM, but will defer to @viveklak to approve since I'm not as familiar with this codebase.

lblackstone avatar Aug 18 '22 18:08 lblackstone

Thanks for the PR @bob-bins !

viveklak avatar Aug 18 '22 19:08 viveklak