pulumi-eks icon indicating copy to clipboard operation
pulumi-eks copied to clipboard

Expose more internal helpers

Open gitfool opened this issue 6 years ago • 2 comments

This probably applies to more than this repo, but here is an example use case. I'm trying to customize the cluster and node group. This creeps to needing to specify iam roles and instance profiles, and looking around seems to require the same boiler plate everywhere. 😞

Specifically, all the examples have the same iam.ts, which overlaps with the ServiceRole ctor that isn't exported.

Ideally, this class is exposed for external use. I like its use of sha1 hash in the role name. It could also be improved by exposing another helper, or similar, that returned the minimum default policy arns, as copied in all the examples too. That way they could be conveniently available to be used as is or combined with other custom policies when calling the ServiceRole ctor.

gitfool avatar Sep 12 '19 18:09 gitfool

@CyrusNajmabadi @metral is ServiceRole something that might make sense for awsx?

pgavlin avatar Sep 12 '19 18:09 pgavlin

Related:

  • https://github.com/pulumi/pulumi-eks/pull/239#discussion_r320428225
  • https://github.com/pulumi/pulumi-eks/pull/98#issuecomment-480452516

metral avatar Sep 12 '19 23:09 metral