pulumi-azure-native icon indicating copy to clipboard operation
pulumi-azure-native copied to clipboard

Initial sketch of using azcore client

Open mikhailshilkov opened this issue 1 year ago • 3 comments

I haven't wired it anywhere, so it's no functional change, but I was playing with azcore to see if it solves #903 (it does not) and implemented the minimal version of CRUD. It worked for resource groups/vnets/subnets, but obviously lots of work to do to make it universal and then gradually introduce it to users.

First step towards #1464

@thomas11 @danielrbradley @mjeffryes Do you folks think it's worth pursuing?

mikhailshilkov avatar Mar 06 '24 15:03 mikhailshilkov

Does the PR have any schema changes?

Looking good! No breaking changes found. No new resources/functions.

github-actions[bot] avatar Mar 06 '24 15:03 github-actions[bot]

Nice! I think it's definitely worth pursuing since we have to do #1464 at some point. The question is, as always, prioritization, i.e., when to do it.

thomas11 avatar Mar 06 '24 15:03 thomas11

Codecov Report

Attention: Patch coverage is 0% with 108 lines in your changes missing coverage. Please review.

Project coverage is 60.26%. Comparing base (1586bd5) to head (fc82f2c). Report is 176 commits behind head on master.

Files with missing lines Patch % Lines
provider/pkg/azure/client_azcore.go 0.00% 108 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3128      +/-   ##
==========================================
- Coverage   60.83%   60.26%   -0.58%     
==========================================
  Files          71       72       +1     
  Lines       11353    11461     +108     
==========================================
  Hits         6907     6907              
- Misses       3883     3991     +108     
  Partials      563      563              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 06 '24 15:03 codecov[bot]