pulumi-az-pipelines-task
pulumi-az-pipelines-task copied to clipboard
Task fails when using threaded comments and comment thread has already been resolved
Describe the bug Task fails when using threaded comments and comment thread has already been resolved. Error message is produced is below.
##[error]TypeError: Cannot read property '$value' of undefined
To Reproduce Steps to reproduce the behavior:
- Create a pipeline that uses the task to preview changes with threaded PR comments
- Create a PR
- Run pipeline
- Resolve comments
- Run pipeline
- See error
Expected behavior Pipeline task should create a new comment is previous comment has been resolved.
Additional context Issue does not occur when using threaded PR comments.
Error is likely due to source being undefined on line 198 of buildAndReleaseTask/prComment.ts
Error is likely due to source being undefined on line 198 of
Looks like it. Probably ok for the filter to just check if that's undef and filter out in that case.
^Yes. We've encountered similar errors in the GitHub Action.
@Frassle Have we been able to progress on this since the error may have been identified?
Not yet, mostly just been a case of no one having time to pick up anything from this codebase.