pulumi-awsx icon indicating copy to clipboard operation
pulumi-awsx copied to clipboard

TemplateParameters is a funny name

Open joeduffy opened this issue 6 years ago • 2 comments

I found the property templateParameters and corresponding type `TemplateParameters, to be awkwardly named: https://github.com/pulumi/pulumi-awsx/blob/27e8d976c2bb4e856937af90ad2633b6ad11e568/nodejs/awsx/autoscaling/autoscaling.ts#L386

I think it's named this way because we happen to implement the auto-scaling group using a CloudFormation template and stack? If yes, shouldn't this be an implementation detail, and we should instead give them more logical names that don't leak this detail?

joeduffy avatar May 19 '19 22:05 joeduffy

This was one of the tougher spaces we've had to map into the awsx space. I recall the problem at the time was that we're very strongly trying to avoid 'implementation details' as that was a core impediment in the 'cloud' space. So, instead, we're more trying to take a white-box approach where the details are open and avialable for you to manipulate and interact with. This created the somewhat wonky situation with ASGs where hte internal impl is the CF stuff.

I def think there's room for improvement here, so we'll def keep this open. But it's not entirely obvious to me which direction to take while trying to follow some of our design goals more consistently.

CyrusNajmabadi avatar May 20 '19 04:05 CyrusNajmabadi

Unfortunately, it looks like this issue hasn't seen any updates in a while. If you're still experiencing this issue, could you leave a quick comment to let us know so we can prioritize it?

github-actions[bot] avatar Jul 25 '25 04:07 github-actions[bot]