pulumi-aws icon indicating copy to clipboard operation
pulumi-aws copied to clipboard

Tracking: remove tags related patches

Open corymhall opened this issue 7 months ago • 4 comments

This is a tracking ticket to track what needs to be done in order to remove all of our patches / bridge hooks related to tagging and revert to upstream's tagging behavior.

An initial draft PR was done here https://github.com/pulumi/pulumi-aws/pull/4219.

Background

The original work to fix tagging on the Pulumi side was done in #2655. There was a lot of limitations in using default_tags in Terraform which we decided to circumvent be merging default_tags into the resource's tags via a PreCheckCallback function. Since then most of the upstream issues (https://github.com/hashicorp/terraform-provider-aws/issues/29747, https://github.com/hashicorp/terraform-provider-aws/issues/29842, https://github.com/hashicorp/terraform-provider-aws/issues/24449) have been fixed.

The additional patches / custom code adds to the maintenance burden and makes upgrades much harder due to merge conflicts. Since many of the original upstream issues have been fixed, it may be possible to remove our custom tag handling and revert back to upstream behavior.

Patches to remove

  • patches/0029-Fix-markTagsAllNotComputedForResources-to-recognize-.patch
  • patches/0027-Do-not-compute-tags_all-at-TF-level.patch
  • patches/0001-Add-TagsSchemaTrulyComputed-definition.patch
  • patches/0030-Optimize-startup-performance.patch
  • patches/0032-DisableTagSchemaCheck-for-PF-provider.patch
  • patches/0033-Run-scripts-patch_computed_only.sh-to-patch-eks-pod_.patch
  • patches/0035-Fix-tags_all-Computed-for-PF-resources.patch
  • patches/0039-Patch-osis_pipeline-tags-flags.patch
  • patches/0041-Do-not-Compute-tags_all-of-aws_bedrock_provisioned_m.patch
  • patches/0043-securitylake_subscriber-tags_all-patch.patch
  • patches/0044-Patch-tags-ComputedOnly-for-m2-resources.patch
  • patches/0053-Patch-tags-ComputedOnly-on-bedrockagent-and-other-mo.patch
  • patches/0055-Fix-tags_all-Computed-for-aws_datazone_domain.patch
  • patches/0058-Fix-tags_all-Computed-for-PF-resources.patch
  • patches/0059-Fix-tags_all-Computed-for-PF-resources.patch
  • patches/0060-Fix-tags_all-Computed-for-PF-resources.patch
  • patches/0062-Patch-tags-ComputedOnly-for-appfabric-networkmonitor.patch

Patches to update (switch tags_all back to Computed)

  • patches/0042-fix-legacy-bucket-context.patch
  • patches/0014-add-matchmaking-configuration-72.patch
### Tasks
- [ ] Rollout `PlanResourceChange` for all resources
- [ ] Fix aws_s3_legacy_bucket to work with `PlanResourceChange`
- [ ] [TestTagsCombinationsGo/regress_2](https://github.com/pulumi/pulumi-aws/blob/335cac45a6d895a29b35b0a0c5755736b557d93d/examples/examples_go_test.go#L92-L96) fails. The Tag value is not removed.
- [ ] [TestAccDefaultTags (Don't specify any default tags)](https://github.com/pulumi/pulumi-aws/blob/335cac45a6d895a29b35b0a0c5755736b557d93d/examples/examples_yaml_test.go#L197-L201) fails. The Tag value is not removed.

corymhall avatar Jul 15 '24 19:07 corymhall