pulumi-aws icon indicating copy to clipboard operation
pulumi-aws copied to clipboard

Upstream v5.48.0

Open t0yv0 opened this issue 9 months ago • 6 comments

Upgrades upstream to v5.48.0

Fixes https://github.com/pulumi/pulumi-aws/issues/3890

t0yv0 avatar May 06 '24 19:05 t0yv0

Does the PR have any schema changes?

Found 2 breaking changes:

Resources

  • 🟢 "aws:fsx/ontapFileSystem:OntapFileSystem": required inputs: "storageCapacity" input has changed to Required

Types

  • 🟡 "aws:bcmdata/ExportTimeouts:ExportTimeouts": properties: "delete" missing

New resources:

  • bedrock/agentAgentKnowledgeBaseAssociation.AgentAgentKnowledgeBaseAssociation

Maintainer note: consult the runbook for dealing with any breaking changes.

github-actions[bot] avatar May 06 '24 20:05 github-actions[bot]

Is README.md missing any configuration options?

assumeRoleWithWebIdentity not found in Configuration section customCaBundle not found in Configuration section defaultTags not found in Configuration section ec2MetadataServiceEndpoint not found in Configuration section ec2MetadataServiceEndpointMode not found in Configuration section httpProxy not found in Configuration section httpsProxy not found in Configuration section ignoreTags not found in Configuration section noProxy not found in Configuration section retryMode not found in Configuration section s3UsEast1RegionalEndpoint not found in Configuration section sharedConfigFiles not found in Configuration section skipRequestingAccountId not found in Configuration section stsRegion not found in Configuration section tokenBucketRateLimiterCapacity not found in Configuration section useDualstackEndpoint not found in Configuration section

Please add a description for each of these options to README.md. Details about them can be found in either the upstream docs or schema.json.

github-actions[bot] avatar May 06 '24 20:05 github-actions[bot]

Looks like the regression test is catching an actual problem. We introduced custom retry for KMS condition on lambda invocation and it has regressed because upstream is moving from Go SDK v1 to Go SDK V2:

https://github.com/pulumi/pulumi-aws/pull/3234

t0yv0 avatar May 07 '24 15:05 t0yv0

Fixed the patch to use AWS SDKv2 and trying this again.

t0yv0 avatar May 07 '24 17:05 t0yv0

aws_bedrockagent_agent_knowledge_base_association mapping to bedrock/agentAgentKnowledgeBaseAssociation.AgentAgentKnowledgeBaseAssociation is unfortunate, perhaps can do better here.

t0yv0 avatar May 07 '24 18:05 t0yv0

TestAccWebserverComp flake.

t0yv0 avatar May 07 '24 19:05 t0yv0

I'm running into some difficulties with moving bedrockanalysis resources namely https://github.com/pulumi/pulumi-terraform-bridge/issues/1937

Going to backlog this and take the change later.

t0yv0 avatar May 08 '24 16:05 t0yv0