pulumi-aws-native icon indicating copy to clipboard operation
pulumi-aws-native copied to clipboard

SQS Queue Redrive Policy typing

Open kg-jcaron opened this issue 1 year ago • 6 comments

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

The SQS redrivePolicy is not strictly typed (uses any in typescript, object in dotnet). Everything seems to work correctly with it, but it would be nice to have strict typing for the property names (deadLetterTargetArn and maxReceiveCount) like in the aws classic provider if possible.

kg-jcaron avatar Feb 07 '24 22:02 kg-jcaron

Thanks for pointing this out @kg-jcaron it should be possible to generate more useful types here.

mjeffryes avatar Feb 08 '24 01:02 mjeffryes

This appears to be an issue with the upstream specifications.

The type of this field is currently specified as: https://github.com/pulumi/pulumi-aws-native/blob/550eb8c0c6559a06d584fc996e2ab58f7af97d69/aws-cloudformation-schema/aws-sqs-queue.json#L83-L86

However in the CloudFormation documentation it more accurately describes the type as having two fields:

{ "deadLetterTargetArn" : String, "maxReceiveCount" : Integer }

This also applies to RedriveAllowPolicy.

danielrbradley avatar Mar 06 '24 11:03 danielrbradley

@danielrbradley Have you reported this in https://github.com/aws-cloudformation/cloudformation-coverage-roadmap/? (that's the upstream repo we should report CF issues to)

mikhailshilkov avatar Mar 12 '24 17:03 mikhailshilkov

No, I've not written this up as an issue for them yet. For some providers there's also separate repositories in https://github.com/aws-cloudformation/ for their specific implementations which are worth checking too for issues.

danielrbradley avatar Apr 02 '24 14:04 danielrbradley

Let's report the upstream issue as the first step

mikhailshilkov avatar Apr 02 '24 14:04 mikhailshilkov

Reported: https://github.com/aws-cloudformation/cloudformation-coverage-roadmap/issues/2012

danielrbradley avatar Apr 17 '24 13:04 danielrbradley