examples icon indicating copy to clipboard operation
examples copied to clipboard

Use `provided.al2` AWS Go Lambda runtime to fix build process

Open Luke-Rogerson opened this issue 1 year ago • 4 comments

What?

This PR updates this example to use the now required provided.al2 AWS Go Lambda runtime, along with necessary related changes.

Why?

Running pulumi up in this example results in the following error:

InvalidParameterValueException: The runtime parameter of go1.x is no longer supported for creating or updating AWS Lambda functions. 
We recommend you use a supported runtime while creating or updating functions.

go1.x runtime Lambdas must now be migrated to provided.al2023 or provided.al2 runtimes.

Luke-Rogerson avatar Aug 26 '24 20:08 Luke-Rogerson

PR is now waiting for a maintainer to run the acceptance tests. Note for the maintainer: To run the acceptance tests, please comment /run-example-tests on the PR

github-actions[bot] avatar Aug 26 '24 20:08 github-actions[bot]

Bump! 😃

Luke-Rogerson avatar Sep 01 '24 20:09 Luke-Rogerson

Anyone?!

Luke-Rogerson avatar Sep 19 '24 12:09 Luke-Rogerson

Can I get a review?

Luke-Rogerson avatar Oct 10 '24 16:10 Luke-Rogerson

PR is now waiting for a maintainer to run the acceptance tests. Note for the maintainer: To run the acceptance tests, please comment /run-example-tests on the PR

github-actions[bot] avatar Nov 25 '24 19:11 github-actions[bot]

can you rebase real quick and I will /run-example-tests?

rshade avatar Jan 09 '25 15:01 rshade

PR is now waiting for a maintainer to run the acceptance tests. Note for the maintainer: To run the acceptance tests, please comment /run-example-tests on the PR

github-actions[bot] avatar Jan 09 '25 20:01 github-actions[bot]

can you rebase real quick and I will /run-example-tests?

Thank you, sir. I have rebased.

Luke-Rogerson avatar Jan 09 '25 21:01 Luke-Rogerson

PR is now waiting for a maintainer to run the acceptance tests. Note for the maintainer: To run the acceptance tests, please comment /run-example-tests on the PR

github-actions[bot] avatar Jan 09 '25 21:01 github-actions[bot]

PR is now waiting for a maintainer to run the acceptance tests. Note for the maintainer: To run the acceptance tests, please comment /run-example-tests on the PR

github-actions[bot] avatar Jan 09 '25 21:01 github-actions[bot]

Thank you for you contribution. These look good to me. Once the tests run I will merge.

Great! Seems some issue loading AWS credentials in the tests btw

Luke-Rogerson avatar Jan 10 '25 08:01 Luke-Rogerson

/run-example-tests

rshade avatar Jan 10 '25 12:01 rshade

@Luke-Rogerson looks like I am going to have to pull you into a local branch to run it.

rshade avatar Jan 10 '25 13:01 rshade