examples icon indicating copy to clipboard operation
examples copied to clipboard

Published 20 hours ago • verified publisher icon pulumi

Update a number of dotnet examples (mostly aws)

Open Zaid-Ajaj opened this issue 3 years ago • 2 comments

This PR updates a bunch of dotnet examples as well as the CI to use latest dotnet v6. It addresses examples

  • aws-cs-s3-folder
  • aws-cs-webserver
  • aws-cs-secrets-manager
  • aws-assume-role
  • aws-cs-eks

Simplifying the examples to use top-level statements as well as getting rid of big chunks of interpolated JSON strings to use JsonObject definitions instead (when specifying IAM policies)

More to come, this is to make PR size manageable and discuss whether these changes are good for us to apply to the other examples as well

Zaid-Ajaj avatar Jun 30 '22 11:06 Zaid-Ajaj

Unit tests are failing, looking into them now but also trying to figure a better way to define mocks.

Zaid-Ajaj avatar Jun 30 '22 12:06 Zaid-Ajaj

@Zaid-Ajaj Should we get this to a merge or close it out?

mikhailshilkov avatar Feb 02 '23 10:02 mikhailshilkov