docs icon indicating copy to clipboard operation
docs copied to clipboard

Azure containerregistry credentialset Go doc has incorrect type

Open jaxxstorm opened this issue 2 years ago • 0 comments

This page: https://www.pulumi.com/registry/packages/azure-native/api-docs/containerregistry/credentialset/

Has the following code:

_, err := containerregistry.NewCredentialSet(ctx, "credentialSet", &containerregistry.CredentialSetArgs{
			AuthCredentials: []containerregistry.AuthCredentialArgs{
				{
					Name:                     pulumi.String("Credential1"),
					PasswordSecretIdentifier: pulumi.String("https://myvault.vault.azure.net/secrets/password"),
					UsernameSecretIdentifier: pulumi.String("https://myvault.vault.azure.net/secrets/username"),
				},
			},
			CredentialSetName: pulumi.String("myCredentialSet"),
			Identity: &containerregistry.IdentityPropertiesArgs{
				Type: containerregistry.ResourceIdentityTypeSystemAssigned,
			},
			LoginServer:       pulumi.String("docker.io"),
			RegistryName:      pulumi.String("myRegistry"),
			ResourceGroupName: pulumi.String("myResourceGroup"),
		})
		if err != nil {
			return err
		}

The correct way of doing this:

credentialSet, err := containerregistry.NewCredentialSet(ctx, "credentialSet", &containerregistry.CredentialSetArgs{
			AuthCredentials: containerregistry.AuthCredentialArray{
				&containerregistry.AuthCredentialArgs{
					Name:                     pulumi.String("Credential1"),
					PasswordSecretIdentifier: pulumi.String("https://myvault.vault.azure.net/secrets/password"),
					UsernameSecretIdentifier: pulumi.String("https://myvault.vault.azure.net/secrets/username"),
				},
			},
			CredentialSetName: pulumi.String("myCredentialSet"),
			Identity: &containerregistry.IdentityPropertiesArgs{
				Type: containerregistry.ResourceIdentityTypeSystemAssigned,
			},
			LoginServer:       pulumi.String("docker.io"),
			RegistryName:      pulumi.String("myRegistry"),
			ResourceGroupName: pulumi.String("myResourceGroup"),
		})
		if err != nil {
			return err
		}
		return nil

jaxxstorm avatar Sep 14 '23 14:09 jaxxstorm