docs icon indicating copy to clipboard operation
docs copied to clipboard

Published 20 hours ago • verified publisher icon pulumi

Auto-merge merges a PR without waiting for the build to complete

Open mikhailshilkov opened this issue 4 years ago • 4 comments

pulumi-bot merges a PR in docs as soon as I approve it without waiting for the build to complete. Example: https://github.com/pulumi/docs/pull/5989

Two undesired effects:

  • A potentially broken PR is merged
  • Clean-up runs before the preview is ready, so the preview resources remain hanging

mikhailshilkov avatar May 17 '21 13:05 mikhailshilkov

@mikhailshilkov is docs the right place for this issue? or should it be in home? i guess i mean, is this issue specific to the docs repo?

susanev avatar Apr 02 '22 01:04 susanev

I only saw it in docs but I'm not sure it doesn't happen elsewhere

mikhailshilkov avatar Apr 02 '22 17:04 mikhailshilkov

I'll investigate whether this is still an issue.

cnunciato avatar Apr 02 '22 20:04 cnunciato

Indeed, still an issue: https://github.com/pulumi/docs/pull/7438#issuecomment-1114319502

cnunciato avatar May 01 '22 19:05 cnunciato