actions
actions copied to clipboard
feat: update action runtime to NodeJS 16
Close https://github.com/pulumi/actions/issues/752
As a result, actions authors who move from targeting Node.js 12 to Node.js 16 should release with a new major version number to communicate that there is a possible breaking change for GitHub Enterprise Server 3.3 and earlier.
https://github.blog/changelog/2022-05-20-actions-can-now-run-in-a-node-js-16-runtime/ - Github recommends to update major version of action if runtime changes.
Let me know if you would like to keep v3, then I'll revert it back
Thanks for this PR @ahanoff . We won't be able to merge until December for the reasons stated in the linked issue, but we'll revisit this PR at that time. 👍🏻 It's very nice to have a PR ready-and-waiting to merge for when the upstream becomes unblocked! :)
GH has delayed the deprecation of GHE v3.3 until 18 Jan 2023. As a result, that's the new "do not merge until" date for this PR. :(
@RobbieMcKinstry can you please elaborate on the need to wait for that specific date? what's preventing us from updating to node16 or node18 and shipping a new version that uses an up-to-date node version right now?
Hi @dotansimha https://github.com/pulumi/actions/issues/752 has a more detailed write-up. Technically, there's nothing stopping us from cutting a new major release right now.
https://github.blog/changelog/2023-01-18-code-scanning-codeql-action-v1-is-now-deprecated/
let me update branch to make it ready for merge
@ahanoff, I've rebased this branch off of master, and I'm making a few other tweaks so we can get this in 👍🏻