actions icon indicating copy to clipboard operation
actions copied to clipboard

feat: update action runtime to NodeJS 16

Open ahanoff opened this issue 2 years ago • 1 comments

Close https://github.com/pulumi/actions/issues/752

As a result, actions authors who move from targeting Node.js 12 to Node.js 16 should release with a new major version number to communicate that there is a possible breaking change for GitHub Enterprise Server 3.3 and earlier.

https://github.blog/changelog/2022-05-20-actions-can-now-run-in-a-node-js-16-runtime/ - Github recommends to update major version of action if runtime changes.

Let me know if you would like to keep v3, then I'll revert it back

ahanoff avatar Oct 13 '22 03:10 ahanoff

Thanks for this PR @ahanoff . We won't be able to merge until December for the reasons stated in the linked issue, but we'll revisit this PR at that time. 👍🏻 It's very nice to have a PR ready-and-waiting to merge for when the upstream becomes unblocked! :)

RobbieMcKinstry avatar Oct 14 '22 15:10 RobbieMcKinstry

GH has delayed the deprecation of GHE v3.3 until 18 Jan 2023. As a result, that's the new "do not merge until" date for this PR. :(

RobbieMcKinstry avatar Dec 07 '22 16:12 RobbieMcKinstry

@RobbieMcKinstry can you please elaborate on the need to wait for that specific date? what's preventing us from updating to node16 or node18 and shipping a new version that uses an up-to-date node version right now?

dotansimha avatar Dec 21 '22 17:12 dotansimha

Hi @dotansimha https://github.com/pulumi/actions/issues/752 has a more detailed write-up. Technically, there's nothing stopping us from cutting a new major release right now.

RobbieMcKinstry avatar Dec 23 '22 14:12 RobbieMcKinstry

https://github.blog/changelog/2023-01-18-code-scanning-codeql-action-v1-is-now-deprecated/

let me update branch to make it ready for merge

ahanoff avatar Jan 19 '23 05:01 ahanoff

@ahanoff, I've rebased this branch off of master, and I'm making a few other tweaks so we can get this in 👍🏻

RobbieMcKinstry avatar Jan 19 '23 17:01 RobbieMcKinstry