actions icon indicating copy to clipboard operation
actions copied to clipboard

fix: no output issue

Open simenandre opened this issue 3 years ago • 8 comments

No clue why tests are failing 🤷‍♂️

might fix #731

simenandre avatar Oct 06 '22 19:10 simenandre

@RobbieMcKinstry Would you mind having a look at this? Do you see why the tests are failing?

simenandre avatar Oct 06 '22 19:10 simenandre

@cobraz Sure, let me take a look...

RobbieMcKinstry avatar Oct 07 '22 17:10 RobbieMcKinstry

@cobraz Just wondering, are you not able to see the Actions logs? For example, does this link work for you? That's the link to the test failure in CI.

Screen Shot 2022-10-07 at 1 39 42 PM

I'm seeing type error in the logs: The test failure claims getExecOutput isn't a function.

RobbieMcKinstry avatar Oct 07 '22 17:10 RobbieMcKinstry

Oh, yes. I've seen this issue, but I don't know why. I don't wanna bug you with this, just wanted a second pair of eyes

simenandre avatar Oct 07 '22 17:10 simenandre

Understood! Don't worry about bugging me, it's no bother at all :) I just wanted to make sure I understood the ask. Happy to lend a second set of eyes! I'm going to pull down the code locally now. 👍🏻 I appreciate you taking a stab at #731.

RobbieMcKinstry avatar Oct 07 '22 18:10 RobbieMcKinstry

I'm sorry if my original comment came off as rude. I didn't mean to sound dismissive or curt! Apologies!

RobbieMcKinstry avatar Oct 07 '22 18:10 RobbieMcKinstry

Just a quick update. I pushed a change that fixed the broken test.

exec was mocked out in Jest, so switching to getExecOutput required the mock to be updated.

RobbieMcKinstry avatar Oct 07 '22 19:10 RobbieMcKinstry

I also rebased.

RobbieMcKinstry avatar Oct 07 '22 19:10 RobbieMcKinstry

Let's land this anyway?

simenandre avatar Oct 18 '22 18:10 simenandre

@RobbieMcKinstry Rebased now, wanna give this a quick review?

simenandre avatar Oct 18 '22 18:10 simenandre

Holy moly, I'm sorry I missed the notification for this! Very sorry about that!

RobbieMcKinstry avatar Nov 09 '22 01:11 RobbieMcKinstry