fix: no output issue
No clue why tests are failing 🤷♂️
might fix #731
@RobbieMcKinstry Would you mind having a look at this? Do you see why the tests are failing?
@cobraz Sure, let me take a look...
@cobraz Just wondering, are you not able to see the Actions logs? For example, does this link work for you? That's the link to the test failure in CI.
I'm seeing type error in the logs: The test failure claims getExecOutput isn't a function.
Oh, yes. I've seen this issue, but I don't know why. I don't wanna bug you with this, just wanted a second pair of eyes
Understood! Don't worry about bugging me, it's no bother at all :) I just wanted to make sure I understood the ask. Happy to lend a second set of eyes! I'm going to pull down the code locally now. 👍🏻 I appreciate you taking a stab at #731.
I'm sorry if my original comment came off as rude. I didn't mean to sound dismissive or curt! Apologies!
Just a quick update. I pushed a change that fixed the broken test.
exec was mocked out in Jest, so switching to getExecOutput required the mock to be updated.
I also rebased.
Let's land this anyway?
@RobbieMcKinstry Rebased now, wanna give this a quick review?
Holy moly, I'm sorry I missed the notification for this! Very sorry about that!