nextcloud-oidc-login icon indicating copy to clipboard operation
nextcloud-oidc-login copied to clipboard

Published 20 hours ago • verified publisher icon pulsejet

Support for pkce

Open Firstyear opened this issue 4 years ago • 2 comments
trafficstars

https://datatracker.ietf.org/doc/html/rfc7636

There are some openid connect providers that required PKCE to function correctly, which it appears that this plugin doesn't support in it's requests. It would be great if this could be updated to have PKCE S256 functionality.

For more: https://medium.com/swlh/pkce-flow-of-openid-connect-9b10ddbabd66

Thanks!

Firstyear avatar Nov 10 '21 03:11 Firstyear

PKCE is supported by OpenID-Connect-PHP and implementation should be quite easy.

Are you interested in opening a PR?

azmeuk avatar Oct 18 '22 20:10 azmeuk

I can not code in PHP, so I can not contribute sorry.

Firstyear avatar Oct 18 '22 23:10 Firstyear

Created a PR for this, please see https://github.com/pulsejet/nextcloud-oidc-login/pull/203

R0Wi avatar Nov 05 '22 17:11 R0Wi