memories icon indicating copy to clipboard operation
memories copied to clipboard

Add path to sidebar

Open illnesse opened this issue 3 years ago • 6 comments

Haven't had the time to debug this one yet, but i'm getting it often and i can reproduce it reliably

  • Select a photo
  • open "view in folder" in a new tab
  • both tabs freeze for a couple seconds (maybe due to reflow? idk)

image image image

this is probably not much help yet, i'll keep you posted

illnesse avatar Nov 07 '22 19:11 illnesse

The view in folder button does basically nothing beside opening a new tab, so not sure where to begin 😄

Do you also see this if opening it from the new viewer?

pulsejet avatar Nov 07 '22 20:11 pulsejet

I think the issue is a files app problem as View in folder opens the preview of an image in the foreground, but with a folder consisting of several thousand photos in the background (like fo example "Photos from 2021" from Google Takeout in my case) Probably not much you can do about that, it's just Nextcloud being Nextcloud. They really should be using lazy load for longer lists like dir listings

Actually i only use this feature to find out the exact path of a file, because currently there is no other way to see the full path of selected photos, maybe you could add that to the sidebar somehow, then we won't have to use the slow nextcloud default apps as much :D

illnesse avatar Nov 10 '22 09:11 illnesse

Ah yes, that makes sense. The files app does do lazy loading, but it needs to load the entire thing to scroll to a particular file. Not much we can do there, but adding the full path to the sidebar makes sense.

pulsejet avatar Nov 11 '22 04:11 pulsejet

I'm kinda stuck about the design for this. #68 shows how the sidebar looks. There seems no easy way to put a unix path in here without looking ugly ...

pulsejet avatar Nov 12 '22 02:11 pulsejet

image

image

maybe something like this? i just put it in the EXIF tab to see how it would look, no idea if you even have access to that.. i'll look at the vue code and might do a PR when i get around to it, it still needs some icon paddding and white-space / word-wrap / max-width magic, or maybe wrap it in <pre> so it just wraps around at the end of the line ignoring whitespace

illnesse avatar Nov 12 '22 13:11 illnesse

That looks nice! Should be straightforward to implement, we already have the path somewhere in Vue. I'll let you take this one: really need more people to get into the code ;)

Making it a bit smaller / monospace might also be interesting.

pulsejet avatar Nov 12 '22 14:11 pulsejet

Just chiming in here to agree that adding it to the exif (now called info) tab seems like the logical place for this to show up (especially that it's now called "info")

meichthys avatar Aug 23 '23 14:08 meichthys

This is now available as an option image image

pulsejet avatar Aug 25 '23 19:08 pulsejet