pulse icon indicating copy to clipboard operation
pulse copied to clipboard

remove fallback date for `nextRunAt`

Open fermentfan opened this issue 1 year ago • 3 comments

This just creates wrong data. Old jobs that have been executed already and will not be executed again appear as jobs that will run at the current date (as their date is null). It should just be null instead like it is written in the persistence layer. No need for a fallback.

Is this behaviour important for some other logic?

fermentfan avatar Oct 10 '24 19:10 fermentfan

@fermentfan As of now, deleting this value may cause side effects. Please post the specific case where deleting this is necessary in the issue, and I will take a look.

code-xhyun avatar Oct 11 '24 02:10 code-xhyun

We simply query jobs like this:

await this.pulse.jobs({ type: 'normal' });

This returns a set of jobs, in which all jobs that originally have a null 'nextRunAt' in mongodb, have the fallback applied.

fermentfan avatar Oct 11 '24 05:10 fermentfan

개인적인 사정으로 인해 프로젝트 관리에 어려움을 겪었습니다. 이번 달부터 점진적으로 프로젝트 관리를 재개할 계획입니다.

code-xhyun avatar Apr 14 '25 08:04 code-xhyun