browser icon indicating copy to clipboard operation
browser copied to clipboard

Correct browser branding

Open PressJump opened this issue 2 years ago • 9 comments

There are several hardwritten nightly branding images/text scattered around the browser. As a result, the browser cannot be rebranded using the configuration files and must be done manually.

This issue has been created for tracking reasons around rebranding nightly.

Things that are broken

  • [ ] MacOS's installer file is put in the wrong location (#36)
  • [ ] Windows full installer has nightly images (engine/browser/branding/*/wiz*.bmp)
  • [ ] Windows 10/11 use nightly images
  • [ ] The windows installer puts our code in Mozilla Developer Preview
  • [x] Browser help branding
  • [x] MacOS still uses nightly icons (#81 )
  • [x] MacOS still uses Nightly name (#81 )
  • [x] Default Firefox Bookmarks
  • [ ] Private Browsing using Logo Nightly

PressJump avatar Apr 23 '22 05:04 PressJump

All changes should be made within gluon's branding generation (gluon/src/commands/patches/brandingPatch.ts).

trickypr avatar Apr 24 '22 04:04 trickypr

Automation closed this when it shouldn't have

trickypr avatar May 21 '22 11:05 trickypr

Default Firefox bookmarks are injected into the users profile by default. By default removing them or alternatively It may be a good idea to replace them with a pulse variant that is relative to the features, updates and help pages of pulse browser. Adding it to the list for now.

PressJump avatar Sep 27 '22 06:09 PressJump

#114

PressJump avatar Sep 29 '22 00:09 PressJump

Nightly branding on new private browsing window (incognito).

PressJump avatar Oct 05 '22 20:10 PressJump

New version of Firefox comes with Firefox View which needs a rebranding and removal in some parts of the browser.

PressJump avatar Oct 20 '22 11:10 PressJump

I was just going to remove firefox view. From the input I have seen so far, people don't really like it

trickypr avatar Oct 20 '22 11:10 trickypr

OS based branding is still Nightly on some systems.

PressJump avatar Nov 11 '22 07:11 PressJump

According to searchfox, “Mozilla Developer Preview” is located in branding/unofficial/branding.nsi, under the brand full name.

1A4A4050-B9B3-4865-9845-8510761984B6

splatboydev avatar Dec 31 '22 09:12 splatboydev