Ctrl-F when text is selected in a diff tab (github package) should feed the search field

[Tamaranch]

Thanks in advance for your bug report!

• [X] Have you reproduced issue in safe mode?
• [X] Have you used the debugging guide to try to resolve the issue?
• [X] Have you checked our FAQs to make sure your question isn't answered there?
• [X] Have you checked to make sure your issue does not already exist?
• [X] Have you checked you are on the latest release of Pulsar?

What happened?

Just as it would from a normal source file. Currently, you have to copy-paste the selected text after pressing Ctrl-F. This may be more of an enhancement request than a bug, but I think it would make life easier.

Pulsar version

1.114.0

Which OS does this happen on?

🐧 Arch based (Manjaro, Garuda, etc.)

OS details

Arch Linux

Which CPU architecture are you running this on?

x86_64/AMD64

What steps are needed to reproduce this?

• Click on a modified file in the git pane to open a diff tab
• Select some text
• Press Ctrl-F

Expected result: search bar appears with selected text in the search field. Actual result: search bar appears with the search field empty.

Additional Information:

No response

[savetheclocktower]

I don't know what the convention is on Linux, but if this is how other tools behave, then that makes sense to me.

On macOS, I'd accomplish the same thing by selecting text and pressing Cmd-E, which is a standard shortcut for populating the “Find” field with the selection. I could then do Cmd-G to find the next occurrence, or Cmd-F if I wanted to open the find-and-replace menu in the bottom dock.

So at the very least, this could be achievable by remapping Ctrl-F to a custom command. It'd need to invoke find-and-replace:use-selection-as-file-pattern, then find-and-replace:show.

But you're right that (even on macOS) selecting text in an ordinary Pulsar text editor and pressing Cmd-F populates the search field with that text. It's odd that it doesn't do the same thing with a git diff pane — which, under the hood, is just a fancy read-only instance of TextEditor. This is worth investigating.