Find All - Collapsing files changes scroll position

[evanmhm]

Thanks in advance for your bug report!

• [X] Have you reproduced issue in safe mode?
• [X] Have you used the debugging guide to try to resolve the issue?
• [X] Have you checked our FAQs to make sure your question isn't answered there?
• [X] Have you checked to make sure your issue does not already exist?
• [X] Have you checked you are on the latest release of Pulsar?

What happened?

When viewing a result from the Find All tab (Project Find Results) it saves the tab's scroll position. Then when collapsing the files (by clicking on file path headers) the window snaps to the previously saved scroll position, very annoying when dealing with long lists of find results.

Pulsar version

1.113.2024012501

Which OS does this happen on?

🪟 Windows

OS details

Windows 11

Which CPU architecture are you running this on?

x86_64/AMD64

What steps are needed to reproduce this?

1. When searching across project (control + shift + f) and viewing enough results for the window to scroll
2. Click on a result to open a file
3. Return to search results and scroll down on the page
4. Collapse a file's results by clicking on file path header, and the scroll position will return to the position saved when viewing a result in step 1

Additional Information:

This was an issue in atom as well for as long as I remember. Doesn't make it unusable but it's pretty annoying for my workflow.

[savetheclocktower]

Sorry it took me a while to read this one. I'll take a look when I'm able.

[wincelau]

I don't know how the project works at all, I just looked through the latest changes in case by chance I spot a commit that might be causing the problem, and I noticed these 2 commits : a720d967d702fc80b9037b49066321b8e8a08d31 039ea260b24af54f32a153f4caadcab56edd7914

Maybe I'm totally missing the problem but just in case it might help