pulsar icon indicating copy to clipboard operation
pulsar copied to clipboard

Warning: Could not resolve package to a package path (when uninstalling packages)

Open syrsly opened this issue 1 year ago • 1 comments

Thanks in advance for your bug report!

  • [X] Have you reproduced issue in safe mode?
  • [X] Have you used the debugging guide to try to resolve the issue?
  • [X] Have you checked our FAQs to make sure your question isn't answered there?
  • [X] Have you checked to make sure your issue does not already exist?
  • [X] Have you checked you are on the latest release of Pulsar?

What happened?

Package manager not uninstalling packages properly. Could be related to this other issue: https://github.com/pulsar-edit/pulsar/issues/853

Pulsar version

1.113.0

Which OS does this happen on?

🪟 Windows

OS details

Windows 10 Pro

Which CPU architecture are you running this on?

x86_64/AMD64

What steps are needed to reproduce this?

Install a package and watch the console while uninstalling the same package.

Additional Information:

When uninstalling pulsar-column-select-mode package, for example, it presents a red error in console, saying Failed to load package 'pulsar-column-select-mode' at PackageManager.activatePackage (C:\Program Files\Pulsar\resources\app.asar\src\package-manager.js:776) at C:\Program Files\Pulsar\resources\app.asar\src\package-manager.js:489 at Array.forEach () at C:\Program Files\Pulsar\resources\app.asar\src\package-manager.js:489 at C:\Program Files\Pulsar\resources\app.asar\src\config.js:1156 at Function.simpleDispatch (VM141 C:\Program Files\Pulsar\resources\app.asar\node_modules\event-kit\dist\emitter.js:64) at Emitter.emit (VM141 C:\Program Files\Pulsar\resources\app.asar\node_modules\event-kit\dist\emitter.js:257) at Config.emitChangeEvent (C:\Program Files\Pulsar\resources\app.asar\src\config.js:1354) at Config.setRawValue (C:\Program Files\Pulsar\resources\app.asar\src\config.js:1141) at Config.set (C:\Program Files\Pulsar\resources\app.asar\src\config.js:764) at Config.removeAtKeyPath (C:\Program Files\Pulsar\resources\app.asar\src\config.js:966) at PackageManager.removePackageNameFromDisabledPackages (C:\Program Files\Pulsar\resources\app.asar\node_modules\settings-view\lib\package-manager.js:539) at C:\Program Files\Pulsar\resources\app.asar\node_modules\settings-view\lib\package-manager.js:465 at exit (C:\Program Files\Pulsar\resources\app.asar\node_modules\settings-view\lib\package-manager.js:85) at triggerExitCallback (C:\Program Files\Pulsar\resources\app.asar\src\buffered-process.js:280) at ChildProcess. (C:\Program Files\Pulsar\resources\app.asar\src\buffered-process.js:310) at ChildProcess.emit (events.js:315) at Process.ChildProcess._handle.onexit (internal/child_process.js:277)

Similar errors are given for all other packages. Packages do seem to successfully uninstall, but there could be junk files somewhere. Regardless, no errors should ever be allowed in the uninstall process and should be handled more gracefully than this.

When uninstalling any package, it also says a warning "Could not resolve package to a package path"

syrsly avatar Jan 16 '24 17:01 syrsly

The warnings and errors no longer appear to be present in the latest rolling release.

syrsly avatar Jan 16 '24 17:01 syrsly