pulsar icon indicating copy to clipboard operation
pulsar copied to clipboard

[settings-view] Use new `owner` endpoint instead of `users`

Open confused-Techie opened this issue 2 years ago • 3 comments

This PR builds off of @savetheclocktower's hard work on pulsar-edit/package-backend#215 which allows us to filter owners of package's via query parameter.

So this PR ensures when we link to a code owner, instead of going to their user page, we instead go to the packages page with the proper query parameter set.

confused-Techie avatar Jan 08 '24 05:01 confused-Techie

If I visit https://web.pulsar-edit.dev/owners/DeeDeeG, I get

This Page encountered an Error!
If you think you're seeing this page in error, please report an issue on [GitHub](https://github.com/pulsar-edit/package-frontend/issues) or [Discord](https://discord.gg/7aEbB9dGRT).

        The page '/owners/DeeDeeG' cannot be found.

Is that expected? Does the DB need to be seeded with owner metadata on packages or something? I also tried it with savetheclocktower's and spiker985's usernames, since I figured they would have published packages since https://github.com/pulsar-edit/package-backend/pull/215 landed, and the metadata would presumably be populated at the DB for at least those pacakges?

DeeDeeG avatar Jan 11 '24 04:01 DeeDeeG

To clarify: the frontend part isn't implemented yet (though the owner URL param does work to filter by owner on package search pages). I plan to get to it soon.

I think when this link was put in, the expectation was that the /users/:user endpoint would eventually exist, but it's just been linking to nothing for ages. This improves the situation because at least we have a theoretical plan in place to make this endpoint. :-)

savetheclocktower avatar Jan 11 '24 04:01 savetheclocktower

Yeah thanks for taking a look at this @DeeDeeG, and clarifying the situation @savetheclocktower

Suppose I probably should've made this a draft to indicate more work was needed. But am planning to wait until the frontend work becomes active (Which itself also relies on one more backend change) prior to merging. But thanks for the approval!

confused-Techie avatar Jan 12 '24 00:01 confused-Techie