pulsar icon indicating copy to clipboard operation
pulsar copied to clipboard
verified publisher icon pulsar-edit

Trying to fix windows builds

Open mauricioszabo opened this issue 3 years ago • 6 comments

mauricioszabo avatar Aug 17 '22 18:08 mauricioszabo

@confused-Techie I actually never got it working on Windows :(

mauricioszabo avatar Sep 13 '22 00:09 mauricioszabo

@confused-Techie I actually never got it working on Windows :(

Bummer to hear. Is there any value in this PR then or should it be closed?

confused-Techie avatar Sep 13 '22 00:09 confused-Techie

I think I'll convert it to draft and then just re-use the branch to try different things. If I somehow can make things work, I'll rebase the commits

mauricioszabo avatar Sep 13 '22 00:09 mauricioszabo

Wait, I can't convert to Draft?

mauricioszabo avatar Sep 13 '22 00:09 mauricioszabo

Wait, I can't convert to Draft?

Its got the work-in-progress tag, so it should be known not to commit without further review.

confused-Techie avatar Sep 13 '22 01:09 confused-Techie

Since Windows builds are now working should we go ahead and close this PR?

confused-Techie avatar Sep 25 '22 02:09 confused-Techie

@mauricioszabo Is this still needed?

Spiker985 avatar Dec 19 '22 17:12 Spiker985

Closing as a lot has gone on in this space, and this is wildly out of date now

Spiker985 avatar Apr 20 '23 07:04 Spiker985