pulsar icon indicating copy to clipboard operation
pulsar copied to clipboard

add or update `packages/*/package-lock.json`

Open sertonix opened this issue 3 years ago • 4 comments

This updates or adds the packages/*/package-lock.json files. This is to achieve consistent builds even if single packages are build. And also is a lot more consistent than before.

sertonix avatar Dec 10 '22 18:12 sertonix

Ok cool hopefully this will help me run it using yarn

realwolf2 avatar Dec 10 '22 18:12 realwolf2

Ok cool hopefully this will help me run it using yarn

I don't think this will help, sorry. This should not effect the main build.

sertonix avatar Dec 10 '22 18:12 sertonix

So on this, I'm not sure this will have the effect intended. The main editor should always be built with using yarn which will be ignored in this instance. The bundled packages would then also be built with yarn when the editor is built.

I may recommend that if you wanted to improve the consistency of builds for our bundled packages would be instead to remove all the npm lock files and replace with yarn but even then, I'm not sure if that has an effect or if those deps are then hoisted to the main editor lock file. Which the latter is what I believe is happening

confused-Techie avatar Dec 10 '22 22:12 confused-Techie

Since ppm is using npm internally these lock files would be used if these packages are installed directly. So I would say a npm lock file makes more sense.

sertonix avatar Dec 10 '22 22:12 sertonix