pulsar icon indicating copy to clipboard operation
pulsar copied to clipboard
verified publisher icon pulsar-edit

Properly enable electron logging/send parameters to PPM

Open Spiker985 opened this issue 3 years ago • 2 comments

  • Fixes electron logging, and allows for all output from the internal console to be output to the terminal that launched Pulsar. This was something we didn't even know was broken
  • Sends all parameters found after -p/--package to be sent to PPM. No more overlapped commands!
    • This may cause future problems if there becomes another parameter that needs to take complete ownership of parameters sent afterwards, but we'll cross that bridge when we get to it

Spiker985 avatar Nov 28 '22 08:11 Spiker985

Not sure if this is the fault of this PR, but I'm seeing some tests failing. I've rerun them to confirm it's not a fluke, might want to see if it's something you can look into. But they don't immediately seem to be obviously caused by this PR. But just a heads up.

confused-Techie avatar Nov 29 '22 08:11 confused-Techie

Yeah, let me see if I can get the CI to rerun today, because nothing changed to cause xmllint to not be installed

So I'm unsure as to why it's like this

Spiker985 avatar Nov 29 '22 13:11 Spiker985

@confused-Techie Honestly, I'm so confused about xmllint error that I'm just going to blow up the branch and make a new PR

Spiker985 avatar Dec 19 '22 17:12 Spiker985

@confused-Techie Honestly, I'm so confused about xmllint error that I'm just going to blow up the branch and make a new PR

Yeah I'm sorry about that. Something weird must've happened here. Or maybe an existing bug in whatever head you pulled for this PR. Hopefully we don't see it again on a new one

confused-Techie avatar Dec 20 '22 00:12 confused-Techie