pulsar icon indicating copy to clipboard operation
pulsar copied to clipboard
verified publisher icon pulsar-edit

Standardize theme package names/descriptions

Open Spiker985 opened this issue 3 years ago • 5 comments

  • Rename themes to theme-<ui|syntax>-<theme name> syntax
  • Renamed atom-dark-syntax to theme-syntax-atom-dark
    • Since this is a theme, it can keep the Atom branding as it is an Atom theme
  • Renamed atom-light-syntax to theme-syntax-atom-light
    • Since this is a theme, it can keep the Atom branding as it is an Atom theme
  • Renamed atom-dark-ui to theme-ui-atom-dark
    • Since this is a theme, it can keep the Atom branding as it is an Atom theme
  • Renamed atom-light-ui to theme-ui-atom-light
    • Since this is a theme, it can keep the Atom branding as it is an Atom theme
  • Renamed base16-tomorrow-dark-theme to theme-syntax-base16-tomorrow-dark
  • Renamed base16-tomorrow-light-theme to theme-syntax-base16-tomorrow-light
  • Renamed one-light-syntax to theme-syntax-one-light
  • Renamed one-dark-syntax to theme-syntax-one-dark
  • Renamed one-light-ui to theme-ui-one-light
  • Renamed one-dark-ui to theme-ui-one-dark
  • Renamed solarized-dark-syntax to theme-syntax-solarized-dark
  • Renamed solarized-light-syntax to theme-syntax-solarized-light

Spiker985 avatar Nov 24 '22 04:11 Spiker985

I cannot believe how many specs rely on the names of specific themes and UIs, but the Editor tests / test (ubuntu-20.04) we are getting 33 failures, when we expect 1 or 0. So these will have to be sorted before it can be merged

confused-Techie avatar Nov 24 '22 06:11 confused-Techie

:facepalm: I really gotta start using Ctrl + Shift + F when doing these. Let me get those specs updated

Spiker985 avatar Nov 25 '22 18:11 Spiker985

image ...why...why does it prefix the name with theme?!

Does that mean that I need to update these specs to be theme-theme-syntax-atom-dark?!

Spiker985 avatar Nov 25 '22 18:11 Spiker985

image ...why...why does it prefix the name with theme?!

Does that mean that I need to update these specs to be theme-theme-syntax-atom-dark?!

Yeah wild, based on that I would assume you would have to for the specs. But awesome work, nearly all of the failing tests are fixed

confused-Techie avatar Nov 25 '22 20:11 confused-Techie

@confused-Techie Might I request a review (once the CI finishes)

Spiker985 avatar Dec 03 '22 09:12 Spiker985

Deviation is too much now. Perhaps one day we'll get to do this again.

Spiker985 avatar Aug 30 '23 03:08 Spiker985