pulsar-edit
async atom-protocol-handler
This replaces the uses of sync with async. It also removes a use of fs-plus
This PR looks great, and is absolutely something I think we should be be doing. But I just want to confirm were you personally able to test that things still worked when using this? Such as opening a specific folder or file with the editor still loaded fine?
@confused-Techie To answer your question. I was not able to test this properly. I also don't know how. Would really appreciate if somebody else could test this.
So while as you probably guessed, seems nobody got the chance to test this. If you are willing I'd appreciate either opening up this PR to maintainers to push to, or if you could update it from the master branch?
That way we can grab our new test system, and can see at a much quicker glance if this is working as intended. Since I'd love to finally clear our usage of fs-plus
Mantainers should be able to edit this pr. Also I merged the changes from main.
Alright, since this PR has seen nearly zero activity, I've gone ahead and made some changes.
Since this PR originally did two things:
- Turned this into an async function
- Removed
fs-plususage
Now, the original author was unsure of how to test things still work while using async handling, I've opted rather than finding a way to test this, to remove the async part of this PR. Since really, I'm willing to assume that turning components of Pulsar into async will require more than just making the function async, where we need to ensure other aspects now know to wait on this happening.
So I've just gone ahead and opted to move forward with removing fs-plus usage from here, and if tests are good then we can go ahead and merge this one, as it's quite outdated at this point
Now that I have looked at the code again I know why I was confident to make the change: It is a callback function. So more or less the function already was async it just didn't use that.
@DeeDeeG Thanks for helping to bring this PR across the finish line!
All tests are passing, and changes look good, as always appreciate your contributions sincerely @Sertonix! Lets get this one merged!