[spell-check] Spell checking doesn't work

[Askaholic]

Thanks in advance for your bug report!

• [x] Have you reproduced issue in safe mode?
• [x] Have you used the debugging guide to try to resolve the issue?
• [x] Have you checked our FAQs to make sure your question isn't answered there?
• [x] Have you checked to make sure your issue does not already exist?
• [x] Have you checked you are on the latest release of Pulsar?

What happened?

I've been using pulsar 1.124.0 for the last few months because of the spell check in comments feature. I finally decided to update to the latest version and make the settings change required to enable this again. However, it seems that no spell checking happens at all anymore on version 1.128.0.

My spell-check settings:

Python source file, no spell checking in comments:

No spell checking in README.md file either:

Both of these are spell checked correctly in pulsar 1.124.0. For now I am going to continue running 1.124.0.

$ pulsar --version
Pulsar  : 1.128.0
Electron: 12.2.3
Chrome  : 89.0.4389.128
Node    : 14.16.0

Pulsar version

1.128.0

Which OS does this happen on?

🐧 Debian based (Linux Mint, Ubuntu, etc.)

OS details

Ubuntu 22.04.5 LTS

Which CPU architecture are you running this on?

x86_64/AMD64

What steps are needed to reproduce this?

Install pulsar using the version 1.128.0 .deb release

Additional Information:

No response

[SilentGlasses]

Can you try disabling the plugin and re-enabling it? I am getting spellchecks on markdown

but not Python,

I wonder if that's because engineers sometimes come up with crazy names for their stuff?

[scmu]

Having the same problem here: spell check works in 1.124.0 but not 1.128.0. This happens on and off --- spell check used to not work in some versions of Pulsar priori to 1.124.0.

Hope this can be fixed.

Pulsar version 1.128.0

Which OS does this happen on? Mac OS X

OS details Mac OS Sequoia 15.5

Which CPU architecture are you running this on? Apple Silicon M1

What steps are needed to reproduce this? Install pulsar using the version 1.128.0 binary

[savetheclocktower]

I've just spent 15 minutes trying to reproduce this and I feel like I'm going insane.

I typically don't have the spell-check package enabled, so I enabled it and reloaded my window. After I did that, spell-checking still wouldn't work at all. I tested in a new unsaved buffer set to “plain text” and could not get any red squiggles to show up.

I added some logging to the code and reloaded the window to try again. Still nothing. I wondered if the buffer needed to be saved on disk for spell-check to work, so I saved my file as foo.txt and reloaded the window. Nothing. I figured maybe the “toggle” setting was global and persistent, so I ran Spell Check: Toggle and reloaded the window.

I'm not 100% convinced I got the order right in what I described above, but eventually it started working. Now I'm getting spell-checking on any plain-text document, whether it's saved to disk or brand new. I have no idea what I changed.

I am totally on board with the idea that there is some mysterious behavior going on with this package and that it might not work right initially, but I have no idea what the root cause is.

I'll do some more digging. In the meantime, I didn't want anyone to think this ticket was being ignored. Thanks for reporting it!