pulsar icon indicating copy to clipboard operation
pulsar copied to clipboard

removed packages metadata

Open sertonix opened this issue 3 years ago • 2 comments

This removes the metadata from the build script and the references in the code. This also removes the preload system for core packages.

The removed APIs are:

  • packageJson._atomPackages
  • packageJson._atomMenu
  • AtomEnviroment.prototype.preload
  • PackageManager.prototype.packagesCache
  • PackageManager.prototype.preloadedPackages
  • PackageManager.prototype.preloadPackages
  • Package.prototype.preloadedPackage
  • Package.prototype.preload
  • Package.prototype.finishLoading
  • ThemePackage.prototype.preload
  • KeymapManager.prototype.canLoadBundledKeymapsFromMemory

And changes/disables these:

  • KeymapManager.prototype.loadBundledKeymaps
  • KeymapManager.prototype.onDidLoadBundledKeymaps
  • KeymapManager.prototype.on('did-load-bundled-keymaps')

TODO:

  • [ ] check if settings paths are influenced by this change
  • [x] remove use from metadata settings-view

sertonix avatar Nov 10 '22 10:11 sertonix

So, what did the preload system actually do?

Reading through the commits, it looks like it loaded certain packages before the editor window is actually loaded

Spiker985 avatar Nov 24 '22 02:11 Spiker985

@Spiker985 Exactly. The core packages were partially loaded before the environment was initialized. This caused a lot of extra code for the core packages. It was most likely hood for the snapshot system but causes a lot of inconsistencies.

sertonix avatar Nov 24 '22 06:11 sertonix

I close this cause the changes to KeymapManager are not that correct. #154 is a continuation of this.

sertonix avatar Dec 10 '22 20:12 sertonix