pulsar-edit
test build with updated github for apple silicon
Yes we do. The GitHub fixes are for apple silicon support.
Bence Janos Toth
From: Maurício Szabo @.> Sent: Saturday, November 12, 2022 11:13:06 PM To: pulsar-edit/pulsar @.> Cc: Bence Janos Toth @.>; Author @.> Subject: Re: [pulsar-edit/pulsar] test build with updated github for apple silicon (PR #124)
@mauricioszabo commented on this pull request.
In script/electron-builder.jshttps://github.com/pulsar-edit/pulsar/pull/124#discussion_r1020778488:
},
- "extraMetadata": {
- } -}
- extraMetadata: {},
- asarUnpack: ["node_modules/github/bin/*"],
With the GitHub fixes, do we actually need this asarUnpack key?
— Reply to this email directly, view it on GitHubhttps://github.com/pulsar-edit/pulsar/pull/124#discussion_r1020778488, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADMN6Q7ECIVOPVF2EIWZQ3LWH66ZFANCNFSM6AAAAAAR3Q5UJA. You are receiving this because you authored the thread.Message ID: @.***>
@benonymus, you should open a new PR for asarUnpack since it resolves another issue not related to apple silicon.
@benonymus, you should open a new PR for
asarUnpacksince it resolves another issue not related to apple silicon.
Yeah that is fair. If we say this this is fine by others as well.
This additional issue was only discovered after I made the fix for Apple Silicon.
It fixes this: https://discord.com/channels/992103415163396136/992103415163396139/1040564640062648370
Here is the pr: https://github.com/pulsar-edit/pulsar/pull/140
Technically this pr can be closed. I got what I wanted to try. I think we should merge the pr on the GitHub repo and have a new tag. Then add that to Pulsar instead of my fork.
https://github.com/pulsar-edit/github/pull/2
What do you think @mauricioszabo ?
Like stated above that this should be closed, now especially as we have #186 merged, should we close this one @benonymus?
