crashes when opening files via CLI

[srevenant]

Thanks in advance for your bug report!

• [X] Have you reproduced issue in safe mode?
• [X] Have you used the debugging guide to try to resolve the issue?
• [X] Have you checked our FAQs to make sure your question isn't answered there?
• [X] Have you checked to make sure your issue does not already exist?
• [X] Have you checked you are on the latest release of Pulsar?

What happened?

Sometimes when opening a file via the CLI the app crashes.

This is new since v119

I haven't reproduced this in safe mode because it's already infrequent and hard to reproduce. But I had to check the box so I could submit.

Pulsar version

119

Which OS does this happen on?

🍎 macOS

OS details

Sonoma

Which CPU architecture are you running this on?

x86_64/AMD64

What steps are needed to reproduce this?

Hard to reproduce but:

• Open a project folder.
• Do some things
• from the cli run the command to open another file outside the project

Then it crashes.

It has also happened when simply renaming a file within the project.

Additional Information:

No response

[DeeDeeG]

Hmm, maybe this has something to do with the new macOS Ventura image we were updated to in Cirrus?

Are you on an Apple Silicon Mac or an intel-based Mac?

Thanks for the report.

[DeeDeeG]

Sorry, I skimmed the issue too quickly. I see this is on an intel-based Mac, per the issue template. Well we're still on macOS 12 CI images here on GitHub Actions (x86 builds). Still could be some other thing auto-updated in the CI image, but maybe one of our code changes as well.

I wonder if you have any unusual characters or text encodings in any of your files, not UTF-8? We had to pin to a certain copy of libiconv, and I believe it may have some issues with certain file encodings? It's a C library, so closer toward the sort of thing that might crash then most of our JS code, I suppose.

[savetheclocktower]

Sorry, I skimmed the issue too quickly. I see this is on an intel-based Mac, per the issue template. Well we're still on macOS 12 CI images here on GitHub Actions (x86 builds). Still could be some other thing auto-updated in the CI image, but maybe one of our code changes as well.

Despite the fact that we're producing Intel Mac binaries on macOS 12, we're still using the new libiconv for those builds since 1.119, so I can't rule that out as a cause.