objc-TimesSquare icon indicating copy to clipboard operation
objc-TimesSquare copied to clipboard

Touch-down event should not select date (and related issues)

Open getaaron opened this issue 12 years ago • 2 comments

In the current implementation, dates are selected on touch down, not touch up. This feels awkward, and does not match the native iOS calendar app.

This can be partially resolved by modifying TSQCalendarRowCell on lines #59 and #90 to use UIControlEventTouchUpInside instead of UIControlEventTouchDown. However, the following issues still remain:

  • The cells still capture the touch event, so the user can't scroll if he holds his finger too long
  • There is no hit state (like a light gray when a cell is highlighted but not selected)

I don't know the code base well enough to resolve those other issues without reading through everything. I'm happy to put some work into fixing this if someone can point me in the right direction. (I just opened this project for the first time today.)

For comparison, note that the similar project MNCalendarView doesn't have these issues, although that project is lacking many things available in this one.

getaaron avatar Sep 09 '13 01:09 getaaron

Ah hah! I suspect this puts a finger (pun intended) on why the calendar feels so wrong in our usage. I'll play with it and see how difficult it might be to resolve some of these issues.

I'm curious what design considerations lead to the choice of using TouchDown instead of Up?

randomstep avatar Sep 09 '13 03:09 randomstep

@getaaron probably just add _tableView.canCancelContentTouches = YES; in TSQCalendarView.m when the tableView is initialized.

Soryu avatar Sep 11 '13 13:09 Soryu