objc-TimesSquare icon indicating copy to clipboard operation
objc-TimesSquare copied to clipboard

Published 20 hours ago • verified publisher icon puls

Updated Merge of #25 Against Master

Open blakewatters opened this issue 12 years ago • 5 comments

blakewatters avatar Aug 07 '13 17:08 blakewatters

Additional cleanups layered on top of #25

blakewatters avatar Aug 12 '13 15:08 blakewatters

@blakewatters & @mattgrayson this is a awesome PR. :+1: from me for merging (once @puls`s amendments are in - do you guys need support for this?).

ened avatar Sep 05 '13 13:09 ened

@blakewatters perhaps we should re-test this PR on a real device. I just checked the performance on an iPad2 (iOS7) and the scrolling performance dropped a lot.

ened avatar Sep 23 '13 16:09 ened

I fixed a serious memory / performance issue earlier today on the TAFlights branch on the GateGuru fork. Will update the PR.

This patch needs some more love IMO before merge. I just need to find cycles. Really needs a test suite to make refactoring less risky

On Monday, September 23, 2013, Sebastian Roth wrote:

@blakewatters https://github.com/blakewatters perhaps we should re-test this PR on a real device. I just checked the performance on an iPad2 (iOS7) and the scrolling performance dropped a lot.

— Reply to this email directly or view it on GitHubhttps://github.com/square/objc-TimesSquare/pull/33#issuecomment-24931595 .

To stay sane & productive, I don't live in e-mail. If you need to reach me quickly, try this link: https://awayfind.com/blakewatters

blakewatters avatar Sep 23 '13 23:09 blakewatters

Just heads up for anyone interested in this work: I have elected to cut bait on TimesSquare and implement a new calendar based on collection views (PSTCollectionView or UICollectionView). I will not be picking this effort back up.

blakewatters avatar Dec 04 '13 19:12 blakewatters