pulp
Use new approach to binding fixtures
I would like to have a similar bindings API as we have now in pulpcore (after this change).
As a developer, this approach feels more ergonomic. Other benefits should be equivalent to those discussed in the linked PR.
The only thing to hold you back is that this might be an unwarranted request to bump the pulpcore dependency.
I'm not sure if I understand why it would cause an unwarranted bump request. Do you mean it would require pulpcore bumping because we would import BindingsNamespace (thus requiring a version where it exists)? We can do a try-catch and hardcode that class on exception, it looks like the code is simple enough for us to do that.
But anyway, any good plan to get around that?
I'm not sure if I understand why it would cause an unwarranted bump request. Do you mean it would require pulpcore bumping because we would import
BindingsNamespace(thus requiring a version where it exists)? We can do a try-catch and hardcode that class on exception, it looks like the code is simple enough for us to do that.But anyway, any good plan to get around that?
You nailed it. That's exactly what i was pointing at. Is it a good idea to require more recent pulpcore in order to use more recent testing features only? And maybe it is.
Is it a good idea to require more recent pulpcore in order to use more recent testing features only?
I really can't tell if its a good idea or not. But to avoid the risk of any trouble this might cause, how about just copying BindingNamespace over? Assuming it is the only dependency required, it's a very simple one.