pulp_ansible icon indicating copy to clipboard operation
pulp_ansible copied to clipboard

git_url (and others) are bad fields on collection content

Open mdellweg opened this issue 2 years ago • 3 comments

          I think this assertion fails due to the parallel nature of the test. In other parallel sync tests we sync the amazon.aws collection which means the git sync will use that version already present in the system (name,namespace uniqeuness strikes again) causing the metadata to differ.

Originally posted by @gerrod3 in https://github.com/pulp/pulp_ansible/pull/1711#discussion_r1446892599

mdellweg avatar Jan 10 '24 09:01 mdellweg

We need to remove them. In general, as long as we allow content to be shared, the content itself cannot tell you where it came from.

mdellweg avatar Jan 10 '24 09:01 mdellweg

as long as we're not removing any fields that come from metadata/manifest, this should be fine.

We definitely need to keep fields such as metadata["repository'].

newswangerd avatar Jan 16 '24 13:01 newswangerd

as long as we're not removing any fields that come from metadata/manifest, this should be fine.

We definitely need to keep fields such as metadata["repository'].

That metadata is part of the actual collection artifact, right? Then there's no issue with that.

mdellweg avatar Jan 16 '24 14:01 mdellweg