Is dependence condition missing in compose.folders.yml for pulp_web service

[xm1234567]

Version pulp/pulp-minimal latest f89cae78c76a
pulp/pulp-web latest 69a0e8f150cc

Describe the bug I tired compose.folders.yml, got the following:

[xxx@xxx compose]$ docker compose -f compose.folders.yml up
validating /home/xniu/pulp-oci-images/images/compose/compose.folders.yml: services.pulp_web.depends_on.pulp_api must be a mapping

I changed a bit the compose.folders.yml, added the two condition statements for pulp_api and pulp_content, then the above problem gone:

  pulp_web:
    image: "pulp/pulp-web:latest"
    command: ['/usr/bin/nginx.sh']
    depends_on:
      pulp_api:
        condition: service_healthy
      pulp_content:
        condition: service_healthy

To Reproduce just run docker compose -f compose.folders.yml up

Expected behavior docker compose CLI should be able to run.

[mdellweg]

I'm certain, both versions are allowed per the docker compose docs (or at least were). But the change you made sounds fine. We could use a PR then.

[xm1234567]

I just copy the lines from compose.yml into compose.folder.yml , is it worth a PR? or you can just add in future release :)

[mdellweg]

It's absolutely worth a PR. Also we don't release the compose files from this repository.