pulp-oci-images icon indicating copy to clipboard operation
pulp-oci-images copied to clipboard

Publish debuginfod container image in the registeries

Open RyanSGoldberg opened this issue 3 years ago • 7 comments

Hi there, We would be interested in having the debuginfod container image added into the publication workflow and ultimately the image registries. If you're amenable to something like this I can write up a quick patch for the publish_images.yaml file. Thanks

RyanSGoldberg avatar Jun 22 '22 17:06 RyanSGoldberg

wdyt about https://github.com/pulp/pulp-oci-images/pull/212 ?

fao89 avatar Jun 23 '22 11:06 fao89

I added in a quick fix to include the CLI arguments for debuginfod but otherwise that would work great for us. Thank you

RyanSGoldberg avatar Jun 23 '22 16:06 RyanSGoldberg

Hi, I just wanted to follow up. I saw #212 was closed earlier this morning?

RyanSGoldberg avatar Jul 12 '22 13:07 RyanSGoldberg

it was closed due to lack of review

fao89 avatar Jul 12 '22 13:07 fao89

@fao89 I don't think I have the competency to review this, @RyanSGoldberg you would need to review it then or someone else from our team

ipanova avatar Jul 12 '22 14:07 ipanova

@fao89 @ipanova Upon further review the changes all look good to me. With that being said I'm still new to this code base so I probably shouldn't be the one to review my own proposed changes

RyanSGoldberg avatar Jul 12 '22 14:07 RyanSGoldberg

@mdellweg I see you've done some work in this repo. Would you be able to review #212. Thanks

RyanSGoldberg avatar Jul 13 '22 21:07 RyanSGoldberg