riscv-dbg icon indicating copy to clipboard operation
riscv-dbg copied to clipboard

Published 20 hours ago • verified publisher icon pulp-platform

Fix for issue #58

Open Silabs-ArjanB opened this issue 4 years ago • 6 comments

Fix for #58

  • Added bus error for non-supported sbaccess values
  • Corrected bus error code for non-supported sbaccess values
  • Added bus error for misaligned SBA access attempts

Signed-off-by: Arjan Bink [email protected]

Silabs-ArjanB avatar Oct 08 '20 14:10 Silabs-ArjanB

Hi, could the CI please be started again? (The failure seems unrelated to the committed code)

Silabs-ArjanB avatar Oct 08 '20 16:10 Silabs-ArjanB

Needs a rebase

bluewww avatar Oct 26 '20 16:10 bluewww

@bluewww Merged in master

Silabs-ArjanB avatar Oct 27 '20 08:10 Silabs-ArjanB

I thought about this again, I think its best if we just now allow 8-bit and 16-bit accesses since the code is already in place and seems correct to me see #57

bluewww avatar Oct 28 '20 21:10 bluewww

I thought about this again, I think its best if we just now allow 8-bit and 16-bit accesses since the code is already in place and seems correct to me see #57

Hi @bluewww Fully agreed that that would be the ideal fix. I went down that path first and quickly realized that this is more work than I wanted to invest in this, so instead of adding (not officially required support for) byte and halfword accesses I chose to at least fix the bugs in the currently supported access types. Note that the debugger knows which access types are supported via sbcs (and not supporting all of them is allowed). The code for the byte enables is largely there, but also the wdata, rdata, and address lsb will need fixes to support byte and halfword accesses.

Silabs-ArjanB avatar Oct 29 '20 07:10 Silabs-ArjanB

Hi @bluewww and @Silabs-ArjanB, Please see #106, for adding 8b and 16b accesses

noytzach avatar Jan 04 '21 14:01 noytzach