riscv-dbg icon indicating copy to clipboard operation
riscv-dbg copied to clipboard

WIP: Add a simpler version of the driver compatible with Verilator 5.020

Open thommythomaso opened this issue 1 year ago • 2 comments

thommythomaso avatar Jul 05 '24 15:07 thommythomaso

As from our previous discussion I like and support the idea. Let me know if you need directions.

bluewww avatar Jul 08 '24 12:07 bluewww

As from our previous discussion I like and support the idea. Let me know if you need directions.

Thank you. From a functional perspective, the PR is ready to be reviewed. However, we do not have a solution for backward compatibility yet.

Our idea was to wrap the module-based driver in the more complex class-based driver. After checking the spec (I should have checked before - sorry), it is clear that modules cannot be instantiated within classes. Long story short, we do not yet have a solution to ensure backward compatibility without code duplication.

thommythomaso avatar Jul 08 '24 12:07 thommythomaso

Our idea was to wrap the module-based driver in the more complex class-based driver. After checking the spec (I should have checked before - sorry), it is clear that modules cannot be instantiated within classes.

This may be a more extreme measure, but what if we just replace jtag_test and create a new pre-release version?

As we discussed before, there is no good reason for a non-parametric interface to require virtual interfaces and classes for verification.

Nobody using proper versioning practices should experience any regressions from this change, and updating testbench code to the new module approach is very straightforward.

paulsc96 avatar Feb 26 '25 19:02 paulsc96